-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added cookie provider #495
Conversation
Wow! This is a huge contribution! Thank you @shainegordon! ❤️ Ill approve the workflow and have our CI do an initial runthrough. Once the CI is satisfied I will pass this along for a proper review and we can then look to merge it! |
I see the CI failed.
Unfortunately I will only be able to look at this after the 12th August, as
I just went on holiday and don’t have access to my development environment.
I swear that I looked for a test folder, and didn’t see any, obviously I
was going mad 😅
…On Wed, 26 Jul 2023 at 17:06, Zoey ***@***.***> wrote:
Wow! This is a huge contribution! Thank you @shainegordon
<https://github.com/shainegordon>! ❤️
Ill approve the workflow and have our CI do an initial runthrough. Once
the CI is satisfied I will pass this along for a proper review and we can
then look to merge it!
—
Reply to this email directly, view it on GitHub
<#495 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANCVM4ITHG3JN7O2EEPU7LXSEP43ANCNFSM6AAAAAA2W6PG3M>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Not a problem at all! Ping me once your back and I can relook at it!
We use the playground as our test environment. Both playgrounds are started and it checks if any issues occur! But in your PR its only a simple linting issue! |
@zoey-kaiser I have gone ahead and fixed the linting issues. I've also added a GitHub Action job "test-playground-cookie" to align with the others |
Perfect! I am letting the CI run once again and if everything goes well, I will do some testing! We also need some documentation to the new provider, do you feel comfortable adding it in |
Sure, I will see if I can update the docs sometime this week. I just got back from leave, so have a bit of catching up to do for the day job 😄 |
any updates? |
EAGERLY awaiting this to be merged |
Hi everyone! I want to merge this and begin testing it as soon as we release Hang tight. I have not forgotten about you |
Hi all, i added options to local provider to prevent adding many provider workflows. you can see all here. |
Closed in favour of #564 |
Closes #494 .
Checklist:
#
)